linux-kernel - Re: [PATCH 07/21] ASoC: amd: Add module to determine ACP configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bdbea252-09e4-eb60-acf8-4ea8a1d924c4@linux.intel.com>
Date:   Tue, 30 Nov 2021 10:49:30 -0600
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Daniel Baluta <daniel.baluta@....nxp.com>
Cc:     daniel.baluta@...il.com,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        AjitKumar.Pandey@....com, Liam Girdwood <lgirdwood@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ALSA Development Mailing List <alsa-devel@...a-project.org>,
        Julian.Schroeder@....com, Mark Brown <broonie@...nel.org>,
        linux-mediatek@...ts.infradead.org, Balakishore.pati@....com,
        yc.hung@...iatek.com, vishnuvardhanrao.ravulapati@....com,
        vsreddy@....com, daniel.baluta@....com,
        Bard Liao <bard.liao@...el.com>
Subject: Re: [PATCH 07/21] ASoC: amd: Add module to determine ACP
 configuration




>> --- a/sound/soc/amd/Kconfig
>> +++ b/sound/soc/amd/Kconfig
>> @@ -96,4 +96,10 @@ config SND_SOC_AMD_YC_MACH
>>           Say m if you have such a device.
>>           If unsure select "N".
>>
>> +config SND_AMD_ACP_CONFIG
>> +       tristate "AMD ACP configuration selection"
> 
> This definitely needs proper dependencies, to prevent asking the user
> about this when configuring a kernel without AMD Audio ACP support.
> 
> I would have sent a patch, but...

There's indeed a missing dependency that was fixed in
https://github.com/thesofproject/linux/pull/3284

Daniel, you may want to squash it in an update?

To Geert's point, there may be an additional need to add a

depends on SND_SOC_AMD_ACP

There are also a set of

SND_SOC_AMD_ACPyx options, not sure if any applies as a dependency here?