linux-kernel - Re: [PATCH v9 3/8] dt-bindings: display: Add ingenic,jz4780-dw-hdmi DT Schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 30 Nov 2021 12:19:41 -0600
From:   Rob Herring <robh@...nel.org>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     Daniel Vetter <daniel@...ll.ch>,
        Ezequiel Garcia <ezequiel@...labora.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Kees Cook <keescook@...omium.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Paul Boddie <paul@...die.org.uk>,
        David Airlie <airlied@...ux.ie>,
        Liam Girdwood <lgirdwood@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        Robert Foss <robert.foss@...aro.org>,
        Paul Cercueil <paul@...pouillou.net>,
        "open list:MIPS" <linux-mips@...r.kernel.org>,
        Discussions about the Letux Kernel 
        <letux-kernel@...nphoenux.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Mark Rutland <mark.rutland@....com>,
        Neil Armstrong <narmstrong@...libre.com>,
        devicetree@...r.kernel.org,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Maxime Ripard <maxime@...no.tech>,
        Mark Brown <broonie@...nel.org>,
        Harry Wentland <harry.wentland@....com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Jonas Karlman <jonas@...boo.se>
Subject: Re: [PATCH v9 3/8] dt-bindings: display: Add ingenic,jz4780-dw-hdmi
 DT Schema

On Tue, Nov 30, 2021 at 11:03 AM H. Nikolaus Schaller <hns@...delico.com> wrote:
>
> Hi Rob,
>
> > Am 25.11.2021 um 22:26 schrieb Rob Herring <robh@...nel.org>:
> >
> > On Wed, 24 Nov 2021 22:29:09 +0100, H. Nikolaus Schaller wrote:
> >> From: Sam Ravnborg <sam@...nborg.org>
> >>
> >> Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC.
> >> Based on .txt binding from Zubair Lutfullah Kakakhel
> >>
> >> We also add generic ddc-i2c-bus to synopsys,dw-hdmi.yaml
> >>
> >> Signed-off-by: Sam Ravnborg <sam@...nborg.org>
> >> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
> >> Cc: Rob Herring <robh@...nel.org>
> >> Cc: devicetree@...r.kernel.org
> >> ---
> >> .../display/bridge/ingenic,jz4780-hdmi.yaml   | 76 +++++++++++++++++++
> >> .../display/bridge/synopsys,dw-hdmi.yaml      |  3 +
> >> 2 files changed, 79 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
> >>
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/dist-packages/dtschema/schemas/bridge/bridge/synopsys,dw-hdmi.yaml'
>
> I wasn't able to fix that.
>
> If I change
>
>  allOf:
> -  - $ref: bridge/synopsys,dw-hdmi.yaml#
> +  - $ref: synopsys,dw-hdmi.yaml#

That is correct.

>
> then make dt_binding_check still reports:
>
> Unknown file referenced: [Errno 2] No such file or directory: '/Users/hns/Library/Python/3.7/lib/python/site-packages/dtschema/schemas/bridge/synopsys,dw-hdmi.yaml'

The $id is wrong:

$id: http://devicetree.org/schemas/bridge/ingenic,jz4780-hdmi.yaml#

The path should be:
http://devicetree.org/schemas/display/bridge/ingenic,jz4780-hdmi.yaml#

Rob