linux-kernel - Re: [PATCH 2/2] scsi: qla4xxx: Format SYSFS_FLAG_FW_SEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 30 Nov 2021 12:30:26 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        Nilesh Javali <njavali@...vell.com>,
        Manish Rangankar <mrangankar@...vell.com>,
        "supporter:QLOGIC QL41xxx ISCSI DRIVER" 
        <GR-QLogic-Storage-Upstream@...vell.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "open list:QLOGIC QL41xxx ISCSI DRIVER" <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH 2/2] scsi: qla4xxx: Format SYSFS_FLAG_FW_SEL_BOOT as byte

On 11/30/21 12:29 PM, Florian Fainelli wrote:
> qedi formats SYSFS_FLAG_FW_SEL_BOOT as a byte, and the qla4xxx driver
> does exactly the same thing, align them for consistency.
> 
> Suggested-by: Martin K. Petersen <martin.petersen@...cle.com>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>  drivers/scsi/qla4xxx/ql4_os.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
> index 8987acc24dac..39b2f833eb26 100644
> --- a/drivers/scsi/qla4xxx/ql4_os.c
> +++ b/drivers/scsi/qla4xxx/ql4_os.c
> @@ -5734,7 +5734,7 @@ static ssize_t qla4xxx_show_boot_eth_info(void *data, int type, char *buf)
>  
>  	switch (type) {
>  	case ISCSI_BOOT_ETH_FLAGS:
> -		rc = sprintf(str, "%d\n", SYSFS_FLAG_FW_SEL_BOOT);
> +		rc = sprintf(str, "%hhd\n", (char)SYSFS_FLAG_FW_SEL_BOOT);
>  		break;
>  	case ISCSI_BOOT_ETH_INDEX:
>  		rc = sprintf(str, "0\n");
> @@ -5843,7 +5843,7 @@ qla4xxx_show_boot_tgt_info(struct ql4_boot_session_info *boot_sess, int type,
>  			     (char *)&boot_conn->chap.intr_secret);
>  		break;
>  	case ISCSI_BOOT_TGT_FLAGS:
> -		rc = sprintf(str, "%d\n", SYSFS_FLAG_FW_SEL_BOOT);
> +		rc = sprintf(str, "%hdd\n", (char)SYSFS_FLAG_FW_SEL_BOOT);

Sorry, I botched up that one, let me resend.
-- 
Florian