linux-kernel - Re: [PATCH] x86/fpu/signal: initialize sw_bytes in save_xstate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b740b48e-2675-d324-d35c-d96f973f24e0@intel.com>
Date:   Tue, 30 Nov 2021 13:08:58 -0800
From:   Dave Hansen <dave.hansen@...el.com>
To:     Alexander Potapenko <glider@...gle.com>, tglx@...utronix.de,
        chang.seok.bae@...el.com, bp@...e.de
Cc:     dvyukov@...gle.com, elver@...gle.com, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/fpu/signal: initialize sw_bytes in
 save_xstate_epilog()

On 11/26/21 4:47 AM, Alexander Potapenko wrote:
> save_sw_bytes() did not fully initialize sw_bytes, which caused KMSAN
> to report an infoleak (see below).
> Initialize sw_bytes explicitly to avoid this.
...
> Reported-by: Alexander Potapenko <glider@...gle.com>
> Signed-off-by: Marco Elver <elver@...gle.com>
> Signed-off-by: Alexander Potapenko <glider@...gle.com>
> Tested-by: Alexander Potapenko <glider@...gle.com>
> Fixes: 53599b4d54b9b8dd ("x86/fpu/signal: Prepare for variable sigframe length")
> Link: https://lore.kernel.org/all/CAG_fn=V9T6OKPonSjsi9PmWB0hMHFC=yawozdft8i1-MSxrv=w@mail.gmail.com/

Hi Alexander,

Marco's SoB entry is before yours.  Was this authored by you or Marco?
If it was Marco, it's customary to add a:

	From: Marco Elver <elver@...gle.com>

at the top of the changelog to make sure git gets the author right.  I'm
happy to fix it up this time, I just need to know who wrote it.