linux-kernel - Re: [PATCH V1] mtd: spi-nor: winbond: Add support for winbond chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=W_LAJDKgLf5mZKe9Ku=GSvV=m4Tg=5VLYZWvT8=Ds10Q@mail.gmail.com>
Date:   Tue, 30 Nov 2021 13:31:29 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Shaik Sajida Bhanu <quic_c_sbhanu@...cinc.com>
Cc:     tudor.ambarus@...rochip.com, michael@...le.cc, p.yadav@...com,
        miquel.raynal@...tlin.com, richard@....at, vigneshr@...com,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        stummala@...eaurora.org, vbadigan@...eaurora.org,
        quic_rampraka@...cinc.com, quic_pragalla@...cinc.com,
        sartgarg@...eaurora.org
Subject: Re: [PATCH V1] mtd: spi-nor: winbond: Add support for winbond chip

Hi,

On Thu, Nov 25, 2021 at 10:56 PM Shaik Sajida Bhanu
<quic_c_sbhanu@...cinc.com> wrote:
>
> Add support for winbond W25Q512NW-IM chip.
>
> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@...cinc.com>
> ---
>  drivers/mtd/spi-nor/winbond.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 96573f6..cdfa2ee 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -100,6 +100,9 @@ static const struct flash_info winbond_parts[] = {
>                              SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>         { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
>                             SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> +       {"w25q512nw", INFO(0xef8020, 0, 64 * 1024, 1024,
> +                          SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                          SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
>         { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024,
>                              SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },

I have no comments on the contents of this patch, but your spacing is
off. The entry above and below you have a space between the "{" and
the string with the name of the flash part. You should match.

-Doug