linux-kernel - [PATCH v2] fpga: stratix10-soc: Do not use ret uninitialized in s10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 Nov 2021 15:11:24 -0700
From:   Nathan Chancellor <nathan@...nel.org>
To:     Moritz Fischer <mdf@...nel.org>, Wu Hao <hao.wu@...el.com>,
        Xu Yilun <yilun.xu@...el.com>
Cc:     Nick Desaulniers <ndesaulniers@...gle.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev, Nathan Chancellor <nathan@...nel.org>,
        Russ Weight <russell.h.weight@...el.com>,
        Tom Rix <trix@...hat.com>
Subject: [PATCH v2] fpga: stratix10-soc: Do not use ret uninitialized in s10_probe()

Clang warns:

drivers/fpga/stratix10-soc.c:431:9: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
        return ret;
               ^~~

ret is only assigned in an error path now so just return 0 directly.

Fixes: 4ba0b2c294fe ("fpga: mgr: Use standard dev_release for class driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/1517
Reviewed-by: Russ Weight <russell.h.weight@...el.com>
Reviewed-by: Tom Rix <trix@...hat.com>
Signed-off-by: Nathan Chancellor <nathan@...nel.org>
---

v1 -> v2: https://lore.kernel.org/r/20211129161009.3625548-1-nathan@kernel.org/

* Drop clang's suggestion text (Tom).

* Pick up Russ and Tom's review tags.

 drivers/fpga/stratix10-soc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
index 737d14c6e0de..357cea58ec98 100644
--- a/drivers/fpga/stratix10-soc.c
+++ b/drivers/fpga/stratix10-soc.c
@@ -428,7 +428,7 @@ static int s10_probe(struct platform_device *pdev)
 	}
 
 	platform_set_drvdata(pdev, mgr);
-	return ret;
+	return 0;
 
 probe_err:
 	stratix10_svc_free_channel(priv->chan);

base-commit: 8886a579744fbfa53e69aa453ed10ae3b1f9abac
-- 
2.34.1