linux-kernel - Re: [PATCH] x86/csum: fix initial seed for odd buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e94236d-7e91-80a6-f55d-15bd503e52c4@intel.com>
Date:   Tue, 30 Nov 2021 14:16:17 -0800
From:   Dave Hansen <dave.hansen@...el.com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        Peter Zijlstra <peterz@...radead.org>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Noah Goldstein <goldstein.w.n@...il.com>,
        Alexander Duyck <alexanderduyck@...com>
Subject: Re: [PATCH] x86/csum: fix initial seed for odd buffers

On 11/25/21 6:18 AM, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> When I folded do_csum() into csum_partial(), I missed that we
> had to swap odd/even bytes from @sum argument.
...
> Fixes: df4554cebdaa ("x86/csum: Rewrite/optimize csum_partial()")

Hi Eric,

That Fixes: sha1 doesn't match anything that I can find.  Should it be
Fixes: this commit:

> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/core&id=d31c3c683ee668ba5d87c0730610442fd672525f

I'm happy to fix it up when I apply it.  Just wanted to double-check
what you intended.