linux-kernel - Re: [patch 05/22] genirq/msi: Fixup includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875ys9b71j.ffs@tglx>
Date:   Tue, 30 Nov 2021 23:41:28 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Cédric Le Goater <clg@...d.org>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     linux-hyperv@...r.kernel.org, Paul Mackerras <paulus@...ba.org>,
        sparclinux@...r.kernel.org, Wei Liu <wei.liu@...nel.org>,
        Ashok Raj <ashok.raj@...el.com>, Marc Zygnier <maz@...nel.org>,
        x86@...nel.org, Christian Borntraeger <borntraeger@...ibm.com>,
        Bjorn Helgaas <helgaas@...nel.org>,
        Jason Gunthorpe <jgg@...dia.com>, linux-pci@...r.kernel.org,
        xen-devel@...ts.xenproject.org, ath11k@...ts.infradead.org,
        Kevin Tian <kevin.tian@...el.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Megha Dey <megha.dey@...el.com>,
        Juergen Gross <jgross@...e.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-mips@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [patch 05/22] genirq/msi: Fixup includes

On Tue, Nov 30 2021 at 23:10, Thomas Gleixner wrote:

> On Tue, Nov 30 2021 at 22:48, Cédric Le Goater wrote:
>> On 11/29/21 22:38, Thomas Gleixner wrote:
>>> On Mon, Nov 29 2021 at 08:33, Cédric Le Goater wrote:
>>> thanks for having a look. I fixed up this and other fallout and pushed out an
>>> updated series (all 4 parts) to:
>>> 
>>>          git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel msi
>>
>> pSeries fails to allocate MSIs starting with this patch :
>>
>>   [PATCH 049/101] powerpc/pseries/msi: Let core code check for contiguous ...
>>
>> I will dig in later on.
>
> Let me stare at the core function..

It's not the core function. It's the patch above and I'm a moron.

--- a/arch/powerpc/platforms/pseries/msi.c
+++ b/arch/powerpc/platforms/pseries/msi.c
@@ -359,9 +359,6 @@ static int rtas_prepare_msi_irqs(struct
 	if (quota && quota < nvec)
 		return quota;
 
-	if (type == PCI_CAP_ID_MSIX)
-		return -EINVAL;
-
 	/*
 	 * Firmware currently refuse any non power of two allocation
 	 * so we round up if the quota will allow it.