linux-kernel - Re: [PATCH] firmware_loader: export sysctl registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <183b6172-c04e-42d9-00c5-d760c04f0b96@infradead.org>
Date:   Tue, 30 Nov 2021 14:59:36 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Luis Chamberlain <mcgrof@...nel.org>, akpm@...ux-foundation.org,
        keescook@...omium.org, yzaikin@...gle.com, nixiaoming@...wei.com,
        ebiederm@...ssion.com, steve@....org, gregkh@...uxfoundation.org,
        rafael@...nel.org, tytso@....edu, viro@...iv.linux.org.uk,
        pmladek@...e.com, senozhatsky@...omium.org, rostedt@...dmis.org,
        john.ogness@...utronix.de, dgilbert@...erlog.com,
        jejb@...ux.ibm.com, martin.petersen@...cle.com,
        mcgrof@...badil.infradead.org, linux-scsi@...r.kernel.org
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware_loader: export sysctl registration



On 11/30/21 08:45, Luis Chamberlain wrote:
> The firmware loader fallback sysctl table is always built-in,
> but when FW_LOADER=m the build will fail. We need to export
> the sysctl registration and de-registration. Use the private
> symbol namespace so that only the firmware loader uses these
> calls.
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Fixes: firmware_loader: move firmware sysctl to its own files
> Signed-off-by: Luis Chamberlain <mcgrof@...nel.org>

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Thanks.

> ---
>  drivers/base/firmware_loader/fallback_table.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/base/firmware_loader/fallback_table.c b/drivers/base/firmware_loader/fallback_table.c
> index 51751c46cdcf..255823887c70 100644
> --- a/drivers/base/firmware_loader/fallback_table.c
> +++ b/drivers/base/firmware_loader/fallback_table.c
> @@ -56,10 +56,12 @@ int register_firmware_config_sysctl(void)
>  		return -ENOMEM;
>  	return 0;
>  }
> +EXPORT_SYMBOL_NS_GPL(register_firmware_config_sysctl, FIRMWARE_LOADER_PRIVATE);
>  
>  void unregister_firmware_config_sysctl(void)
>  {
>  	unregister_sysctl_table(firmware_config_sysct_table_header);
>  	firmware_config_sysct_table_header = NULL;
>  }
> +EXPORT_SYMBOL_NS_GPL(unregister_firmware_config_sysctl, FIRMWARE_LOADER_PRIVATE);
>  #endif /* CONFIG_SYSCTL */
> 

-- 
~Randy