linux-kernel - Re: [PATCH 2/2] arm64: dts: Add support for LG Bullhead rev 1.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YaazSDljP80tuiA2@pevik>
Date:   Wed, 1 Dec 2021 00:27:04 +0100
From:   Petr Vorel <petr.vorel@...il.com>
To:     Jean THOMAS <virgule@...nthomas.me>
Cc:     devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht,
        Konrad Dybcio <konradybcio@...il.com>
Subject: Re: [PATCH 2/2] arm64: dts: Add support for LG Bullhead rev 1.0

Hi Jean,

[ Cc Konrad ]

> This commit implements a DTS file for LG Bullhead (Nexus 5X) rev 1.0
> with its matching "qcom,board-id" property.

I wonder if each of new dtb files should contain updated models

msm8992-lg-bullhead-rev-10.dtb:
model = "LG Nexus 5X rev 1.0";

msm8992-lg-bullhead-rev-101.dtb:
model = "LG Nexus 5X rev 1.01";

as it's in downstream sources. Because 10 and 101 are a bit cryptic values.

Otherwise LGTM.

Reviewed-by: Petr Vorel <petr.vorel@...il.com>

Kind regards,
Petr