linux-kernel - RE: [PATCH 1/3] usb: aspeed-vhub: add qualifier descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <HK0PR06MB32028A343BDCF1C719918B8280679@HK0PR06MB3202.apcprd06.prod.outlook.com>
Date:   Tue, 30 Nov 2021 09:30:48 +0000
From:   Neal Liu <neal_liu@...eedtech.com>
To:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        Cai Huoqing <caihuoqing@...du.com>,
        Tao Ren <rentao.bupt@...il.com>,
        Julia Lawall <julia.lawall@...ia.fr>,
        kernel test robot <lkp@...el.com>,
        Sasha Levin <sashal@...nel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>
Subject: RE: [PATCH 1/3] usb: aspeed-vhub: add qualifier descriptor

> -----Original Message-----
> From: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Sent: Tuesday, November 30, 2021 7:41 AM
> To: Neal Liu <neal_liu@...eedtech.com>; Felipe Balbi <balbi@...nel.org>;
> Greg Kroah-Hartman <gregkh@...uxfoundation.org>; Joel Stanley
> <joel@....id.au>; Andrew Jeffery <andrew@...id.au>; Cai Huoqing
> <caihuoqing@...du.com>; Tao Ren <rentao.bupt@...il.com>; Julia Lawall
> <julia.lawall@...ia.fr>; kernel test robot <lkp@...el.com>; Sasha Levin
> <sashal@...nel.org>; linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-aspeed@...ts.ozlabs.org
> Cc: BMC-SW <BMC-SW@...eedtech.com>
> Subject: Re: [PATCH 1/3] usb: aspeed-vhub: add qualifier descriptor
> 
> On Fri, 2021-11-26 at 19:09 +0800, Neal Liu wrote:
> >
> > @@ -417,10 +435,9 @@ enum std_req_rc ast_vhub_std_hub_request(struct
> > ast_vhub_ep *ep,
> >
> >  		/* GET/SET_CONFIGURATION */
> >  	case DeviceRequest | USB_REQ_GET_CONFIGURATION:
> > -		return ast_vhub_simple_reply(ep, 1);
> > +		return ast_vhub_simple_reply(ep, vhub->current_config);
> >  	case DeviceOutRequest | USB_REQ_SET_CONFIGURATION:
> > -		if (wValue != 1)
> > -			return std_req_stall;
> > +		vhub->current_config = wValue;
> >  		return std_req_complete;
> 
> This is odd.. why should we support arbitrary SET_CONFIGURATION for configs
> we don't support ?
> 
> Otherwise looks good.
> 
> Cheers,
> Ben.
> 
This is unnecessary...
I'll remove it in next patch.
Thanks

-Neal