linux-kernel - RE: [PATCH 2/2] watchdog: da9062: reset board on watchdog timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB9PR10MB46524A6D216E65C2428588A680679@DB9PR10MB4652.EURPRD10.PROD.OUTLOOK.COM>
Date:   Tue, 30 Nov 2021 09:41:04 +0000
From:   Adam Thomson <Adam.Thomson.Opensource@...semi.com>
To:     Andrej Picej <andrej.picej@...ik.com>,
        Adam Thomson <Adam.Thomson.Opensource@...semi.com>,
        Support Opensource <Support.Opensource@...semi.com>,
        "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>
CC:     "y.bas@...tec.de" <y.bas@...tec.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2] watchdog: da9062: reset board on watchdog timeout

On 29 November 2021 12:12, Andrej Picej wrote:

> > I'm a little concerned about forcing this change in the driver. There may be
> > platforms which don't want the PMIC to perform a full reset through OTP re-
> read
> > and if we hard code this change then that's impacting those platforms. If we
> > want/need this then I think it should probably be a DT binding for da9061/2
> > which then indicates the behaviour we want.
> 
> Ok, I see the impact this might have on the platforms that are relying
> on the current default setting. I will start on the DT binding
> implementation and submit a new patch.

Thanks. Probably the safest route.

> 
> >
> > NRES_MODE bit also plays a part here as it controls whether or not the nRESET
> > line state is changed as part of the power-down/up process. I'm assuming for
> > your setup this bit is 0?
> >
> We leave NRES_MODE as it is, 0 by default I guess? So do you want a
> separate dt binding for NRES_MODE?

I think the setting very much depends on the customers OTP config selection. For
now we can leave this option. Just wanted to highlight it.