linux-kernel - Re: [BUG] hugetlbfs: Fix issue of preallocation of gigantic pages can't work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ccb002e0-7ea6-5289-0f01-48f1a23eaf46@linux.alibaba.com>
Date:   Tue, 30 Nov 2021 09:41:38 +0800
From:   Baolin Wang <baolin.wang@...ux.alibaba.com>
To:     Zhenguo Yao <yaozhenguo1@...il.com>, mike.kravetz@...cle.com,
        akpm@...ux-foundation.org, mlevitsk@...hat.com
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [BUG] hugetlbfs: Fix issue of preallocation of gigantic pages
 can't work

Hi,

On 2021/11/29 21:38, Zhenguo Yao wrote:
> Preallocation of gigantic pages can't work bacause of commit:b5389086ad7b
> (hugetlbfs: extend the definition of hugepages parameter to support node
> allocation). When nid is NUMA_NO_NODE(-1), alloc_bootmem_huge_page will
> always return without doing allocation. Fix this by adding more check.
> 
> Signed-off-by: Zhenguo Yao <yaozhenguo1@...il.com>

You should add a fixes tag, otherwise LGTM.
Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>

Fixes: b5389086ad7b ("hugetlbfs: extend the definition of hugepages 
parameter to support node allocation")