[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CDAA8BE2-F2B0-4020-AEB3-5C9DD4A6E08C@live.com>
Date: Tue, 30 Nov 2021 12:53:57 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: Marcel Holtmann <marcel@...tmann.org>
CC: Greg KH <gregkh@...uxfoundation.org>,
Thorsten Leemhuis <regressions@...mhuis.info>,
Orlando Chamberlain <redecorating@...tonmail.com>,
Daniel Winkler <danielwinkler@...gle.com>,
Johan Hedberg <johan.hedberg@...el.com>,
"linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Luiz Augusto von Dentz <luiz.dentz@...il.com>,
"regressions@...ts.linux.dev" <regressions@...ts.linux.dev>,
"sonnysasaka@...omium.org" <sonnysasaka@...omium.org>,
"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: [PATCH v8 1/2] Bluetooth: add quirk disabling LE Read Transmit Power
From: Aditya Garg <gargaditya08@...e.com>
Some devices have a bug causing them to not work if they query
LE tx power on startup. Thus we add a quirk in order to not query it
and default min/max tx power values to HCI_TX_POWER_INVALID.
Signed-off-by: Aditya Garg <gargaditya08@...e.com>
Reported-by: Orlando Chamberlain <redecorating@...tonmail.com>
Tested-by: Orlando Chamberlain <redecorating@...tonmail.com>
Link:
https://lore.kernel.org/r/4970a940-211b-25d6-edab-21a815313954@protonmail.com
Fixes: 7c395ea521e6 ("Bluetooth: Query LE tx power on startup")
---
v7 :- Added Tested-by.
v8 :- Fix checkpatch error.
include/net/bluetooth/hci.h | 9 +++++++++
net/bluetooth/hci_core.c | 3 ++-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
index 63065bc01b766c..383342efcdc464 100644
--- a/include/net/bluetooth/hci.h
+++ b/include/net/bluetooth/hci.h
@@ -246,6 +246,15 @@ enum {
* HCI after resume.
*/
HCI_QUIRK_NO_SUSPEND_NOTIFIER,
+
+ /*
+ * When this quirk is set, LE tx power is not queried on startup
+ * and the min/max tx power values default to HCI_TX_POWER_INVALID.
+ *
+ * This quirk can be set before hci_register_dev is called or
+ * during the hdev->setup vendor callback.
+ */
+ HCI_QUIRK_BROKEN_READ_TRANSMIT_POWER,
};
/* HCI device flags */
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index 8d33aa64846b1c..434c6878fe9640 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -619,7 +619,8 @@ static int hci_init3_req(struct hci_request *req, unsigned long opt)
hci_req_add(req, HCI_OP_LE_READ_ADV_TX_POWER, 0, NULL);
}
- if (hdev->commands[38] & 0x80) {
+ if ((hdev->commands[38] & 0x80) &&
+ !test_bit(HCI_QUIRK_BROKEN_READ_TRANSMIT_POWER, &hdev->quirks)) {
/* Read LE Min/Max Tx Power*/
hci_req_add(req, HCI_OP_LE_READ_TRANSMIT_POWER,
0, NULL);
Powered by blists - more mailing lists