[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20211130231130.41f9bfcc35ceda68471bbb0b@kernel.org>
Date: Tue, 30 Nov 2021 23:11:30 +0900
From: Masami Hiramatsu <mhiramat@...nel.org>
To: Heiko Carstens <hca@...ux.ibm.com>
Cc: Shuah Khan <shuah@...nel.org>,
Steven Rostedt <rostedt@...dmis.org>,
linux-kernel@...r.kernel.org,
Alexander Egorenkov <egorenar@...ux.ibm.com>
Subject: Re: [PATCH] selftests/ftrace: make kprobe profile testcase
description unique
On Tue, 30 Nov 2021 13:25:46 +0100
Heiko Carstens <hca@...ux.ibm.com> wrote:
> Commit 32f6e5da83c7 ("selftests/ftrace: Add kprobe profile testcase")
> added a new kprobes testcase, but has a description which does not
> describe what the test case is doing and is duplicating the desription
> of another test case.
> Therefore change the test case description, so it is unique and then
> allows easily to tell which test case actually passed or failed.
Good catch!
This looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@...nel.org>
Thank you,
>
> Reported-by: Alexander Egorenkov <egorenar@...ux.ibm.com>
> Signed-off-by: Heiko Carstens <hca@...ux.ibm.com>
> ---
> tools/testing/selftests/ftrace/test.d/kprobe/profile.tc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/profile.tc b/tools/testing/selftests/ftrace/test.d/kprobe/profile.tc
> index 98166fa3eb91..34fb89b0c61f 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/profile.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/profile.tc
> @@ -1,6 +1,6 @@
> #!/bin/sh
> # SPDX-License-Identifier: GPL-2.0
> -# description: Kprobe dynamic event - adding and removing
> +# description: Kprobe profile
> # requires: kprobe_events
>
> ! grep -q 'myevent' kprobe_profile
> --
> 2.32.0
>
--
Masami Hiramatsu <mhiramat@...nel.org>
Powered by blists - more mailing lists