linux-kernel - Re: [PATCH] driver: pmc_atom: free pmc->regmap in pmc_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211130145056.GZ18178@kadam>
Date:   Tue, 30 Nov 2021 17:50:56 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Dongliang Mu <mudongliangabcd@...il.com>
Cc:     Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] driver: pmc_atom: free pmc->regmap in pmc_setup_dev

On Tue, Nov 30, 2021 at 10:35:25PM +0800, Dongliang Mu wrote:
> Smatch reports:
> 
> drivers/platform/x86/pmc_atom.c:496
> pmc_setup_dev() warn: 'pmc->regmap' not released on lines: 496.
> 
> Fix this by deallocating pm->regmap.
> 
> CC: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Dongliang Mu <mudongliangabcd@...il.com>
> ---
>  drivers/platform/x86/pmc_atom.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
> index a9d2a4b98e57..95ba108ed716 100644
> --- a/drivers/platform/x86/pmc_atom.c
> +++ b/drivers/platform/x86/pmc_atom.c
> @@ -492,6 +492,7 @@ static int pmc_setup_dev(struct pci_dev *pdev, const struct pci_device_id *ent)
>  		dev_warn(&pdev->dev, "platform clocks register failed: %d\n",
>  			 ret);
>  
> +	iounmap(pmc->regmap);

This releases it on the success path so it will break the driver.

regards,
dan carpenter

>  	pmc->init = true;
>  	return ret;
>  }
> -- 
> 2.25.1