linux-kernel - Re: linux-next: boot failure after merge of the akpm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211202084434.7d9bde87@canb.auug.org.au>
Date:   Thu, 2 Dec 2021 08:44:34 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Luis Chamberlain <mcgrof@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Xiaoming Ni <nixiaoming@...wei.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: boot failure after merge of the akpm tree

Hi Luis,

On Wed, 1 Dec 2021 11:13:39 -0800 Luis Chamberlain <mcgrof@...nel.org> wrote:
>
> On Tue, Nov 30, 2021 at 08:21:52AM -0800, Luis Chamberlain wrote:
> > On Tue, Nov 30, 2021 at 06:46:22PM +1100, Stephen Rothwell wrote:  
> > > Bisected to commit
> > > 
> > >   f00ff38c1dfa ("sysctl: add and use base directory declarer and registration helper")
> > > 
> > > I have reverted that complete 6 patch series for today.  
> > 
> > I'll be trying to reproduce and fix, thanks for the report!  
> 
> OK please try this patch, I can boot with this just fine on ppc64le:
> 
> diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h
> index 70acd2a100fd..180adf7da785 100644
> --- a/include/linux/sysctl.h
> +++ b/include/linux/sysctl.h
> @@ -201,6 +201,7 @@ static struct ctl_table _name##_base_table[] = {			\
>  		.mode		= 0555,					\
>  		.child		= _table,				\
>  	},								\
> +	{ },								\
>  }
>  
>  extern int __register_sysctl_base(struct ctl_table *base_table);

That fixes it for me.  I will use that in linux-next today instead of
the reverts.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped