[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20211201222638.GB586@quicinc.com>
Date: Wed, 1 Dec 2021 14:26:38 -0800
From: Vamsi Krishna Lanka <quic_vamslank@...cinc.com>
To: Bjorn Andersson <bjorn.andersson@...aro.org>
CC: <agross@...nel.org>, <mturquette@...libre.com>, <sboyd@...nel.org>,
<robh+dt@...nel.org>, <tglx@...utronix.de>, <maz@...nel.org>,
<linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
<manivannan.sadhasivam@...aro.org>, Rob Herring <robh@...nel.org>,
Vinod Koul <vkoul@...nel.org>
Subject: Re: [PATCH v5 6/6] dt-bindings: clock: Introduce pdc bindings for
SDX65
On Fri, Nov 26, 2021 at 04:06:16PM -0800, Bjorn Andersson wrote:
> On Thu 18 Nov 22:11 PST 2021, quic_vamslank@...cinc.com wrote:
>
> > From: Vamsi Krishna Lanka <quic_vamslank@...cinc.com>
> >
> > Add compatible for SDX65 pdc.
> >
> > Signed-off-by: Vamsi Krishna Lanka <quic_vamslank@...cinc.com>
> > Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> > Acked-by: Rob Herring <robh@...nel.org>
> > Reviewed-by: Vinod Koul <vkoul@...nel.org>
>
> Sorry for not spotting this before, but as you can tell from the path of
> the file you're changing, this has nothing to do with "clocks".
>
> git log on qcom,pdc.txt shows that $subject should be:
>
> dt-bindings: qcom,pdc: Add compatible for SDX65
>
> Also, as this is unrelated to clocks, Stephen is not going to merge this
> patch. You will have to repost it, with Marc Zyngier as recipient to get
> it merged; per get_maintainer.
>
>
> I think it's fine to keep the reviews and acks while adjusting $subject
> and reposting this patch - separate from the other 5 patches.
Thank you for the review. Will repost this as a new patch.
Thanks,
Vamsi
>
> Thanks,
> Bjorn
>
> > ---
> > .../devicetree/bindings/interrupt-controller/qcom,pdc.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
> > index 98d89e53013d..ce631d853db4 100644
> > --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
> > @@ -23,6 +23,7 @@ Properties:
> > - "qcom,sdm845-pdc": For SDM845
> > - "qcom,sdm8250-pdc": For SM8250
> > - "qcom,sdm8350-pdc": For SM8350
> > + - "qcom,sdx65-pdc": For SDX65
> >
> > - reg:
> > Usage: required
> > --
> > 2.33.1
> >
Powered by blists - more mailing lists