linux-kernel - Re: [PATCH v2 01/20] ASoC: dt-bindings: Add binding for Tegra20 S/PDIF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YagJ3rKTmE3xSGg4@robh.at.kernel.org>
Date:   Wed, 1 Dec 2021 17:48:46 -0600
From:   Rob Herring <robh@...nel.org>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Liam Girdwood <lgirdwood@...il.com>,
        Agneli <poczt@...tonmail.ch>, linux-tegra@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2 01/20] ASoC: dt-bindings: Add binding for Tegra20
 S/PDIF

On Fri, Nov 26, 2021 at 07:17:48PM +0300, Dmitry Osipenko wrote:
> Add device-tree binding for Tegra20 S/PDIF controller.
> 
> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> ---
>  .../bindings/sound/nvidia,tegra20-spdif.yaml  | 85 +++++++++++++++++++
>  1 file changed, 85 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra20-spdif.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra20-spdif.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra20-spdif.yaml
> new file mode 100644
> index 000000000000..00240205817d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra20-spdif.yaml
> @@ -0,0 +1,85 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/nvidia,tegra20-spdif.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NVIDIA Tegra20 S/PDIF Controller
> +
> +description: |
> +  The S/PDIF controller supports both input and output in serial audio
> +  digital interface format. The input controller can digitally recover
> +  a clock from the received stream. The S/PDIF controller is also used
> +  to generate the embedded audio for HDMI output channel.
> +
> +maintainers:
> +  - Thierry Reding <treding@...dia.com>
> +  - Jon Hunter <jonathanh@...dia.com>
> +
> +properties:
> +  compatible:
> +    const: nvidia,tegra20-spdif
> +
> +  reg:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    minItems: 2
> +
> +  clock-names:
> +    items:
> +      - const: spdif_out
> +      - const: spdif_in

'spdif_' is redundant.

Otherwise,

Reviewed-by: Rob Herring <robh@...nel.org>