linux-kernel - Re: [PATCH v2 rebased 3/9] powerpc/mm: Remove CONFIG_PPC_MM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1638337392.ccyk5edcqo.astroid@bobo.none>
Date:   Wed, 01 Dec 2021 15:50:24 +1000
From:   Nicholas Piggin <npiggin@...il.com>
To:     alex@...ti.fr, Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Michael Ellerman <mpe@...erman.id.au>,
        Paul Mackerras <paulus@...ba.org>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v2 rebased 3/9] powerpc/mm: Remove CONFIG_PPC_MM_SLICES

Excerpts from Christophe Leroy's message of November 26, 2021 3:52 am:
> CONFIG_PPC_MM_SLICES is always selected by hash book3s/64.
> CONFIG_PPC_MM_SLICES is never selected by other platforms.
> 
> Remove it.

I guess there is some remnants of code/data to build 64s hash without 
slices. Maybe without any huge page support? I guess it's probably
broken if it never =n, and not worth maintaining anyway?

Reviewed-by: Nicholas Piggin <npiggin@...il.com>

> 
> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>
> ---
>  arch/powerpc/include/asm/book3s/64/hash.h |  4 ++--
>  arch/powerpc/include/asm/hugetlb.h        |  2 +-
>  arch/powerpc/include/asm/paca.h           |  7 -------
>  arch/powerpc/include/asm/slice.h          | 13 ++-----------
>  arch/powerpc/kernel/paca.c                |  5 -----
>  arch/powerpc/mm/book3s64/Makefile         |  3 +--
>  arch/powerpc/mm/book3s64/hash_utils.c     | 14 --------------
>  arch/powerpc/platforms/Kconfig.cputype    |  4 ----
>  8 files changed, 6 insertions(+), 46 deletions(-)