linux-kernel - RE: [PATCH v1 1/2] i2c: designware-pci: Add support for Fast Mode Plus and High Speed Mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB36609A77B3F5D7730FA16A52C4689@DM6PR11MB3660.namprd11.prod.outlook.com>
Date:   Wed, 1 Dec 2021 05:51:58 +0000
From:   "D, Lakshmi Sowjanya" <lakshmi.sowjanya.d@...el.com>
To:     Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Wolfram Sang <wsa@...nel.org>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Senthil, Bala" <bala.senthil@...el.com>,
        "N, Pandith" <pandith.n@...el.com>
CC:     "Saha, Tamal" <tamal.saha@...el.com>
Subject: RE: [PATCH v1 1/2] i2c: designware-pci: Add support for Fast Mode
 Plus and High Speed Mode



>-----Original Message-----
>From: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
>Sent: Tuesday, November 30, 2021 1:22 PM
>To: Wolfram Sang <wsa@...nel.org>; D, Lakshmi Sowjanya
><lakshmi.sowjanya.d@...el.com>; linux-i2c@...r.kernel.org; linux-
>kernel@...r.kernel.org; Senthil, Bala <bala.senthil@...el.com>; N, Pandith
><pandith.n@...el.com>
>Subject: Re: [PATCH v1 1/2] i2c: designware-pci: Add support for Fast Mode
>Plus and High Speed Mode
>
>On 11/29/21 6:56 PM, Wolfram Sang wrote:
>> On Tue, Nov 09, 2021 at 04:05:51PM +0530, lakshmi.sowjanya.d@...el.com
>wrote:
>>> From: Lakshmi Sowjanya D <lakshmi.sowjanya.d@...el.com>
>>>
>>> Add support to configure HCNT, LCNT values for Fast Mode Plus and
>>> High Speed Mode.
>>>
>>> Signed-off-by: Lakshmi Sowjanya D <lakshmi.sowjanya.d@...el.com>
>>
>> Applied to for-next, thanks!
>>
>>> +	u32 fp_lcnt;
>>> +	u32 hs_lcnt;
>>>   	u32 sda_hold;
>>
>> Short question unrelated to this patch. Why are all these u32...
>>
>>>   		dev->ss_hcnt = cfg->ss_hcnt;
>>>   		dev->fs_hcnt = cfg->fs_hcnt;
>>
>> ... and the ones in dev are u16? Wouldn't it be easier if they all had
>> the same type?
>>
>True, only sda_hold(_time) is u32 and other timing parameters are u16.
>
>Lakshmi: Would you like to send a patch fixing this and get more contributions
>to the driver :-)

Thanks Wolfram and Jarkko,

Sure. I will send a patch fixing it.

Thanks,
Lakshmi
>
>Originally this discrepancy was introduced 2014 by the commit 8efd1e9ee3bd
>("i2c: designware-pci: set ideal HCNT, LCNT and SDA hold time value").
>
>Jarkko