linux-kernel - [PATCH v2 1/2] cpufreq: Fix a comment in cpufreq_policy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211201071500.28648-2-tangyizhou@huawei.com>
Date:   Wed, 1 Dec 2021 15:14:59 +0800
From:   Tang Yizhou <tangyizhou@...wei.com>
To:     <viresh.kumar@...aro.org>, <rafael.j.wysocki@...el.com>,
        <rafael@...nel.org>
CC:     <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Tang Yizhou <tangyizhou@...wei.com>
Subject: [PATCH v2 1/2] cpufreq: Fix a comment in cpufreq_policy_free

Comment both when CPUFREQ_CREATE_POLICY and CPUFREQ_REMOVE_POLICY
notification are sent.

Signed-off-by: Tang Yizhou <tangyizhou@...wei.com>
---
 drivers/cpufreq/cpufreq.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index e338d2f010fe..e76777881739 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1296,8 +1296,9 @@ static void cpufreq_policy_free(struct cpufreq_policy *policy)
 
 	if (policy->max_freq_req) {
 		/*
-		 * CPUFREQ_CREATE_POLICY notification is sent only after
-		 * successfully adding max_freq_req request.
+		 * Need to send CPUFREQ_REMOVE_POLICY notification if
+		 * max_freq_req request is successfully added.
+		 * See also: CPUFREQ_CREATE_POLICY notification.
 		 */
 		blocking_notifier_call_chain(&cpufreq_policy_notifier_list,
 					     CPUFREQ_REMOVE_POLICY, policy);
@@ -1429,6 +1430,10 @@ static int cpufreq_online(unsigned int cpu)
 			goto out_destroy_policy;
 		}
 
+		/*
+		 * CPUFREQ_CREATE_POLICY notification is sent only after
+		 * successfully adding max_freq_req request.
+		 */
 		blocking_notifier_call_chain(&cpufreq_policy_notifier_list,
 				CPUFREQ_CREATE_POLICY, policy);
 	}
-- 
2.17.1