linux-kernel - Re: [PATCH] rtc: rs5c372: add offset correction support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Dec 2021 09:43:02 +0100
From:   Vincent Whitchurch <vincent.whitchurch@...s.com>
To:     Camel Guo <Camel.Guo@...s.com>
CC:     Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        kernel <kernel@...s.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtc: rs5c372: add offset correction support

On Tue, Nov 30, 2021 at 03:55:43PM +0100, Camel Guo wrote:
> Just realize that the oscillation adjustment registers of r2*, rs5c* are 
> not totally same and all of these differences need to be handled in 
> different way. Hence this patch needs to be updated to cover all cases.

Unless you have the hardware to actually test the other variants,
perhaps it would be safer to just reject them in ->set_offset /
->get_offset for now?  Returning -EINVAL for unsupported types should
make rtc_set_offset() and rtc_get_offset() have the same behaviour as
not implementing the callbacks for these variants.