linux-kernel - Re: [PATCH v3 2/2] x86/tsc: skip tsc watchdog checking for qualified platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878rx4a9p3.ffs@tglx>
Date:   Wed, 01 Dec 2021 11:41:44 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Luming Yu <luming.yu@...il.com>, Feng Tang <feng.tang@...el.com>
Cc:     Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...el.com>,
        "H . Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        the arch/x86 maintainers <x86@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>, paulmck@...nel.org,
        rui.zhang@...el.com, andi.kleen@...el.com,
        Len Brown <len.brown@...el.com>, tim.c.chen@...el.com
Subject: Re: [PATCH v3 2/2] x86/tsc: skip tsc watchdog checking for
 qualified platforms

Luming,

please trim your replies.

On Tue, Nov 30 2021 at 23:45, Luming Yu wrote:

> We do need to decouple tsc from HPET as the current HPET as a
> clocksource watchdog for tsc is only useful to find HPET read skews in
> some circumstances and the variations of HPET read come from many
> different sources. But none of which really came from the tsc quality,
> AFAICT.

Sorry, but I fail to decode this sentence.

> so this patch is in line with my understanding of the problem.
> So , please use  reviewed-by :  luming.yu@...el.com , if it can help
> the merge of the patch. : -)

Please send Reviewed-by as a properly formatted single line tag:

   Reviewed-by: Luming Yu <luming.yu@...el.com>

so it can be picked up by tools automatically. Mangling it into a
sentence just creates extra work for maintainers.

Thanks,

        tglx