linux-kernel - Re: [PATCH v4] KEYS: trusted: Fix trusted key backends when building as module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <98c8df77-22c4-ae83-eefd-f55fbb2891e8@pengutronix.de>
Date:   Wed, 1 Dec 2021 11:47:13 +0100
From:   Ahmad Fatoum <a.fatoum@...gutronix.de>
To:     Jarkko Sakkinen <jarkko@...nel.org>
Cc:     andreas@...mhold.de, James Bottomley <jejb@...ux.ibm.com>,
        Mimi Zohar <zohar@...ux.ibm.com>,
        David Howells <dhowells@...hat.com>,
        James Morris <jmorris@...ei.org>,
        "Serge E . Hallyn" <serge@...lyn.com>,
        Sumit Garg <sumit.garg@...aro.org>,
        linux-integrity@...r.kernel.org, keyrings@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH v4] KEYS: trusted: Fix trusted key backends when building
 as module

On 01.12.21 11:40, Jarkko Sakkinen wrote:
> On Wed, Dec 01, 2021 at 10:59:00AM +0100, Ahmad Fatoum wrote:
>> From: Andreas Rammhold <andreas@...mhold.de>
>>
>> Before this commit the kernel could end up with no trusted key sources
>> even though both of the currently supported backends (TPM and TEE) were
>> compiled as modules. This manifested in the trusted key type not being
>> registered at all.
>>
>> When checking if a CONFIG_… preprocessor variable is defined we only
>> test for the builtin (=y) case and not the module (=m) case. By using
>> the IS_REACHABLE() macro we do test for both cases.
>>
>> Fixes: 5d0682be3189 ("KEYS: trusted: Add generic trusted keys framework")
>> Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>
>> Reviewed-by: Ahmad Fatoum <a.fatoum@...gutronix.de>
>> Reviewed-by: Sumit Garg <sumit.garg@...aro.org>
>> Signed-off-by: Andreas Rammhold <andreas@...mhold.de>
>> Tested-by: Ahmad Fatoum <a.fatoum@...gutronix.de>
>> Signed-off-by: Ahmad Fatoum <a.fatoum@...gutronix.de>
> 
> Thank you, I picked this.

Excellent. Could I know your opinion on my CAAM Trusted Keys series as well? :-)

Thanks,
Ahmad

> 
> /Jarkko
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |