linux-kernel - Re: [PATCH v1 1/1] gpio: dwapb: clarify usage of the register file version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yad032NkgdpL8eSm@smile.fi.intel.com>
Date:   Wed, 1 Dec 2021 15:13:03 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Serge Semin <fancer.lancer@...il.com>
Cc:     Serge Semin <Sergey.Semin@...kalelectronics.ru>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Hoan Tran <hoan@...amperecomputing.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [PATCH v1 1/1] gpio: dwapb: clarify usage of the register file
 version

On Wed, Dec 01, 2021 at 03:27:34PM +0300, Serge Semin wrote:
> On Tue, Nov 30, 2021 at 06:49:56PM +0200, Andy Shevchenko wrote:
> > First of all, it's obvious that different versions can't be provided
> > simultaneously. Hence, versions can't be bit masks.
> > 
> > Second, due to above we have to mask out the version field in the flags
> > and only that can be evaluated against the certain version.
> > 
> > Clarify all above by:
> >  - introducing GPIO_REG_OFFSET_V1 and GPIO_REG_OFFSET_MASK
> >  - replacing conditional to mask out bits and compare to a version
> > 
> > Luckily there is no functional change (at least intended), so no need
> > to backport this.
> 
> Seems reasonable. Thanks.
> Acked-by: Serge Semin <fancer.lancer@...il.com>

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko