linux-kernel - Re: [PATCH v13 1/4] dt-bindings: dmaengine: Add doc for tegra gpcdma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ad8e88ba-f105-adb5-007e-2458440b9717@nvidia.com>
Date:   Wed, 1 Dec 2021 14:33:31 +0000
From:   Jon Hunter <jonathanh@...dia.com>
To:     Akhil R <akhilrajeev@...dia.com>, Rob Herring <robh@...nel.org>
Cc:     "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        Krishna Yarlagadda <kyarlagadda@...dia.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        Rajesh Gumasta <rgumasta@...dia.com>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        "vkoul@...nel.org" <vkoul@...nel.org>
Subject: Re: [PATCH v13 1/4] dt-bindings: dmaengine: Add doc for tegra gpcdma


On 30/11/2021 09:34, Jon Hunter wrote:

...

>>>> +title: NVIDIA Tegra GPC DMA Controller Device Tree Bindings
>>>> +
>>>> +description: |
>>>> +  The Tegra General Purpose Central (GPC) DMA controller is used for
>>>> +faster
>>>> +  data transfers between memory to memory, memory to device and
>>>> +device to
>>>> +  memory.
>>>> +
>>>> +maintainers:
>>>> +  - Jon Hunter <jonathanh@...dia.com>
>>>> +  - Rajesh Gumasta <rgumasta@...dia.com>
>>>> +
>>>> +allOf:
>>>> +  - $ref: "dma-controller.yaml#"
>>>> +
>>>> +properties:
>>>> +  compatible:
>>>> +    oneOf:
>>>> +      - const: nvidia,tegra186-gpcdma
>>>> +      - items:
>>>> +         - const: nvidia,tegra186-gpcdma
>>>> +         - const: nvidia,tegra194-gpcdma
>>>
>>> Still not how 'compatible' works nor what I wrote out for you.
>> I thought '186' and '194' got interchanged in your previous comment 
>> because it is 194
>> which is the superset of 186 and have got more features than 186.
>> Or probably I did not understand the idea correctly yet. 
> 
> Hi Rob, this is the way around that we want it. Tegra194 is backward 
> compatible with Tegra186. The above does align with what you mentioned 
> before, so I am also not clear what the issue is with the above?


Now I think I understand. It is the order of the 'items' here that is 
key. So what we want is ...

   compatible:
     oneOf:
       - const: nvidia,tegra186-gpcdma
       - items:
          - const: nvidia,tegra194-gpcdma
          - const: nvidia,tegra186-gpcdma

At least this makes the dt_binding_check happy :-)

Jon

-- 
nvpublic