linux-kernel - Re: [RFC PATCH 0/2] workqueue: Fix hotplug races

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211201144844.GB628470@lothringen>
Date:   Wed, 1 Dec 2021 15:48:44 +0100
From:   Frederic Weisbecker <frederic@...nel.org>
To:     Tejun Heo <tj@...nel.org>
Cc:     Lai Jiangshan <jiangshanlai@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "Paul E . McKenney" <paulmck@...nel.org>
Subject: Re: [RFC PATCH 0/2] workqueue: Fix hotplug races

On Tue, Nov 30, 2021 at 06:36:23AM -1000, Tejun Heo wrote:
> On Tue, Nov 30, 2021 at 01:06:10AM +0100, Frederic Weisbecker wrote:
> > While triggering rcutorture splats, I couldn't trace down to the exact
> > cause due to the issue being tracing-unfriendly. But looking at the code,
> > those two potential races look like plausible causes and also after
> > these two patches, I couldn't reproduce the rcutorture issues again (yet...).
> > 
> > Frederic Weisbecker (2):
> >   workqueue: Fix unbind_workers() VS wq_worker_running() race
> >   workqueue: Fix unbind_workers() VS wq_worker_sleeping() race
> 
> Both patches look good to me. Lai, thanks for finding the offending commits.
> Frederic, can you please repost them w/ scheduler folks and tglx cc'd?

Sure, preparing that.

Thanks.

> Thanks.
> 
> -- 
> tejun