linux-kernel - Re: [PATCH] cgroup: Trace event cgroup id fields should be u64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YaeMoCGy2MXQtJ/U@kroah.com>
Date:   Wed, 1 Dec 2021 15:54:24 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     William Kucharski <william.kucharski@...cle.com>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>, Tejun Heo <tj@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cgroup: Trace event cgroup id fields should be u64

On Wed, Dec 01, 2021 at 07:40:43AM -0700, William Kucharski wrote:
> Various trace event fields that store cgroup IDs were declared
> as ints, but cgroup_id(() returns a u64 and the conversion was
> not intended.
> 
> Also remove extraneous spaces in fields that are no longer proper C style.

Shouldn't this be 2 different patches?  When writing "also" that's a
huge hint that the patch should be split up.

So one for the bugfix, and one for the coding style change?

thanks,

greg k-h