linux-kernel - Re: [PATCH net-next v3 1/2] devicetree: bindings: net: Add bindings doc for Sunplus SP7021.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YabWUQdIP288U09d@lunn.ch>
Date:   Wed, 1 Dec 2021 02:56:33 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Wells Lu <wellslutw@...il.com>
Cc:     davem@...emloft.net, kuba@...nel.org, robh+dt@...nel.org,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, p.zabel@...gutronix.de,
        wells.lu@...plus.com, vincent.shih@...plus.com
Subject: Re: [PATCH net-next v3 1/2] devicetree: bindings: net: Add bindings
 doc for Sunplus SP7021.

> +  nvmem-cells:
> +    items:
> +      - description: nvmem cell address of MAC address of 1st MAC
> +      - description: nvmem cell address of MAC address of 2nd MAC
> +
> +  nvmem-cell-names:
> +    description: names corresponding to the nvmem cells of MAC address
> +    items:
> +      - const: mac_addr0
> +      - const: mac_addr1

These are port properties, so put them in the port section.

Also, the name you should use is well defined, "mac-address".  See
nvmem_get_mac_address(). But you won't be able to use that helper
because it take dev, not an of node.

	Andrew