[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <HK0PR06MB3202E90BCA3BC31D6E4C752480689@HK0PR06MB3202.apcprd06.prod.outlook.com>
Date: Wed, 1 Dec 2021 02:09:43 +0000
From: Neal Liu <neal_liu@...eedtech.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC: Felipe Balbi <balbi@...nel.org>, Joel Stanley <joel@....id.au>,
Andrew Jeffery <andrew@...id.au>,
Cai Huoqing <caihuoqing@...du.com>,
Tao Ren <rentao.bupt@...il.com>,
Julia Lawall <julia.lawall@...ia.fr>,
kernel test robot <lkp@...el.com>,
Sasha Levin <sashal@...nel.org>,
"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
"benh@...nel.crashing.org" <benh@...nel.crashing.org>,
BMC-SW <BMC-SW@...eedtech.com>
Subject: RE: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor
> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Sent: Tuesday, November 30, 2021 7:43 PM
> To: Neal Liu <neal_liu@...eedtech.com>
> Cc: Felipe Balbi <balbi@...nel.org>; Joel Stanley <joel@....id.au>; Andrew
> Jeffery <andrew@...id.au>; Cai Huoqing <caihuoqing@...du.com>; Tao Ren
> <rentao.bupt@...il.com>; Julia Lawall <julia.lawall@...ia.fr>; kernel test
> robot <lkp@...el.com>; Sasha Levin <sashal@...nel.org>;
> linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-aspeed@...ts.ozlabs.org;
> benh@...nel.crashing.org; BMC-SW <BMC-SW@...eedtech.com>
> Subject: Re: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor
>
> On Tue, Nov 30, 2021 at 07:38:44PM +0800, Neal Liu wrote:
> > +Ben.
> > ---
> >
> > Support qualifier descriptor to pass USB30CV compliance test.
> >
> > Signed-off-by: Neal Liu <neal_liu@...eedtech.com>
> > ---
>
> The way you wrote this means that everything below the first --- line will be cut
> off if it were to be applied.
>
> That is not what you want.
>
> Please fix.
>
> thanks,
>
> greg k-h
Yes, I'll fix it. Thanks
-Neal
Powered by blists - more mailing lists