linux-kernel - Re: [PATCH] tracing/histograms: String compares should not care about signed values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Dec 2021 11:21:00 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Tom Zanussi <zanussi@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Yafang Shao <laoar.shao@...il.com>,
        Sven Schnelle <svens@...ux.ibm.com>
Subject: Re: [PATCH] tracing/histograms: String compares should not care
 about signed values

On Tue, 30 Nov 2021 12:37:36 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> From 95f7262b44dc54fed8007cc3db8b39cbd16999c6 Mon Sep 17 00:00:00 2001
> From: "Steven Rostedt (VMware)" <rostedt@...dmis.org>
> Date: Tue, 30 Nov 2021 12:31:23 -0500
> Subject: [PATCH] tracing/histograms: String compares should not care about
>  signed values
> 
> When comparing two strings for the "onmatch" histogram trigger, fields
> that are strings use string comparisons, which do not care about being
> signed or not.
> 
> Do not fail to match two string fields if one is unsigned char array and
> the other is a signed char array.
> 
> Link: https://lore.kernel.org/all/20211129123043.5cfd687a@gandalf.local.home/

Looks good to me.

Review-by: Masami Hiramatsu <mhiramatsu@...nel.org>

Thank you,

> 
> Cc: stable@...rk.kernel.org
> Cc: Tom Zanussi <zanussi@...nel.org>
> Cc: Masami Hiramatsu <mhiramat@...nel.org>
> Cc: Yafang Shao <laoar.shao@...il.com>
> Fixes: b05e89ae7cf3b ("tracing: Accept different type for synthetic event fields")
> Reported-by: Sven Schnelle <svens@...ux.ibm.com>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> ---
>  kernel/trace/trace_events_hist.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
> index 9555b8e1d1e3..319f9c8ca7e7 100644
> --- a/kernel/trace/trace_events_hist.c
> +++ b/kernel/trace/trace_events_hist.c
> @@ -3757,7 +3757,7 @@ static int check_synth_field(struct synth_event *event,
>  
>  	if (strcmp(field->type, hist_field->type) != 0) {
>  		if (field->size != hist_field->size ||
> -		    field->is_signed != hist_field->is_signed)
> +		    (!field->is_string && field->is_signed != hist_field->is_signed))
>  			return -EINVAL;
>  	}
>  
> -- 
> 2.31.1
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>