linux-kernel - Re: [PATCH V3] cgroup: Trace event cgroup id fields should be u64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211201121636.4e25c2b8@gandalf.local.home>
Date:   Wed, 1 Dec 2021 12:16:36 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     William Kucharski <william.kucharski@...cle.com>
Cc:     Ingo Molnar <mingo@...hat.com>, Tejun Heo <tj@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3] cgroup: Trace event cgroup id fields should be u64

On Wed,  1 Dec 2021 09:56:58 -0700
William Kucharski <william.kucharski@...cle.com> wrote:

> Various trace event fields that store cgroup IDs were declared as
> ints, but cgroup_id(() returns a u64 and the structures and associated
> TP_printk() calls were not updated to reflect this.
> 
> Fixes: 743210386c03 ("cgroup: use cgrp->kn->id as the cgroup ID")
> Signed-off-by: William Kucharski <william.kucharski@...cle.com>
> ---
>  V3: Reorder structures to avoid leaving alignment padding holes
>  V2: Do not remove tabs from macro definitions
> 
>  include/trace/events/cgroup.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

>From a tracing POV:

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve