linux-kernel - Re: [PATCH] panic: Remove oops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211202144308.70fd454883c1d1e643491471@linux-foundation.org>
Date:   Thu, 2 Dec 2021 14:43:08 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Arjan van de Ven <arjan@...ux.intel.com>
Subject: Re: [PATCH] panic: Remove oops_id.

On Thu, 2 Dec 2021 15:27:13 +0100 Sebastian Andrzej Siewior <bigeasy@...utronix.de> wrote:

> The oops id has been added as part of the end of trace marker for the
> kerneloops.org project. The id is used to automatically identify duplicate
> submissions of the same report. Identical looking reports with different
> a id can be considered as the same oops occurred again.
> 
> The early initialisation of the oops_id can create a warning if the
> random core is not yet fully initialized. On PREEMPT_RT it is
> problematic if the id is initialized on demand from non preemptible
> context.

"problematic" isn't very useful :(

What exactly goes wrong under -rt?

> The kernel oops project is not available since 2017.
> Remove the oops_id.

(googles "linux oops_id")

https://wiki.ubuntu.com/UbuntuWeeklyNewsletter/Issue565#What.2BIBk-s_the_OOPS_ID.3F

Seems someone was using it in 2019.  My search was very brief.

The world wouldn't end if we removed this.  But perhaps it would be better
to replace the oops id with "0" to avoid breaking parsers.

It's just a fairly unique number.  We could use anything.  Simply
jiffies or ktime_get() would suffice?