linux-kernel - Re: [PATCH] net/mlx5: Fix dangling pointer access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c29127290d489ef883aba38e9c471049fd8304fe.camel@nvidia.com>
Date:   Thu, 2 Dec 2021 22:56:28 +0000
From:   Saeed Mahameed <saeedm@...dia.com>
To:     "amhamza.mgc@...il.com" <amhamza.mgc@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "leon@...nel.org" <leon@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net/mlx5: Fix dangling pointer access

On Fri, 2021-12-03 at 03:15 +0500, Ameer Hamza wrote:
> Fix for dangling pointer access reported by Coverity.
> 
> Addresses-Coverity: 1494138 ("Use after free")
> 
> Signed-off-by: Ameer Hamza <amhamza.mgc@...il.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/health.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/health.c
> b/drivers/net/ethernet/mellanox/mlx5/core/health.c
> index 3ca998874c50..856023321972 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/health.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/health.c
> @@ -335,7 +335,7 @@ static int mlx5_health_try_recover(struct
> mlx5_core_dev *dev)
>  {
>         mlx5_core_warn(dev, "handling bad device here\n");
>         mlx5_handle_bad_state(dev);
> -       if (mlx5_health_wait_pci_up(dev)) {
> +       if (dev->timeouts && mlx5_health_wait_pci_up(dev)) {


the proper fix was already submitted and accepted to net:
https://lore.kernel.org/netdev/20211201063709.229103-11-saeed@kernel.org/

Thank you