linux-kernel - Re: [PATCH v2] clk: Use div64_ul instead of do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20211202231515.F410CC00446@smtp.kernel.org>
Date:   Thu, 02 Dec 2021 15:15:14 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     avifishman70@...il.com, cgel.zte@...il.com
Cc:     benjaminfair@...gle.com, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, mturquette@...libre.com,
        openbmc@...ts.ozlabs.org, tali.perry1@...il.com,
        tmaimon77@...il.com, venture@...gle.com, yuenn@...gle.com,
        zealci@....com.cn, cgel.zte@...il.com, deng.changcheng@....com.cn
Subject: Re: [PATCH v2] clk: Use div64_ul instead of do_div

Please fix the subject. It should be "clk: npcm7xx: Use ..."

Quoting cgel.zte@...il.com (2021-11-18 00:28:58)
> From: Changcheng Deng <deng.changcheng@....com.cn>
> 
> do_div() does a 64-by-32 division. Here the divisor is an unsigned long
> which on some platforms is 64 bit wide. So use div64_ul instead of do_div
> to avoid a possible truncation.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@....com.cn>