linux-kernel - RE: [PATCH] PCI: imx: do not remap invalid res

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Dec 2021 00:48:22 +0000
From:   Hongxing Zhu <hongxing.zhu@....com>
To:     "tharvey@...eworks.com" <tharvey@...eworks.com>,
        Jingoo Han <jingoohan1@...il.com>,
        Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        Rob Herring <robh@...nel.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
CC:     open list <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] PCI: imx: do not remap invalid res


> -----Original Message-----
> From: Tim Harvey <tharvey@...eworks.com>
> Sent: Thursday, December 2, 2021 6:07 AM
> To: Jingoo Han <jingoohan1@...il.com>; Gustavo Pimentel
> <gustavo.pimentel@...opsys.com>; Rob Herring <robh@...nel.org>;
> Lorenzo Pieralisi <lorenzo.pieralisi@....com>; Krzysztof Wilczyński
> <kw@...ux.com>; Bjorn Helgaas <bhelgaas@...gle.com>;
> linux-pci@...r.kernel.org
> Cc: open list <linux-kernel@...r.kernel.org>; Hongxing Zhu
> <hongxing.zhu@....com>
> Subject: Re: [PATCH] PCI: imx: do not remap invalid res
> 
> On Mon, Nov 1, 2021 at 11:03 AM Tim Harvey <tharvey@...eworks.com>
> wrote:
> >
> > On imx6 and perhaps others when pcie probes you get a:
> > imx6q-pcie 33800000.pcie: invalid resource
> >
> > This occurs because the atu is not specified in the DT and as such it
> > should not be remapped.
> >
> > Cc: Richard Zhu <hongxing.zhu@....com>
> > Signed-off-by: Tim Harvey <tharvey@...eworks.com>
[Richard Zhu] Please merge Rob's commit log changes.
Then, Acked-by: Richard Zhu <hongxing.zhu@....com>

Best Regards
Richard Zhu
> > ---
> >  drivers/pci/controller/dwc/pcie-designware.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-designware.c
> > b/drivers/pci/controller/dwc/pcie-designware.c
> > index a945f0c0e73d..3254f60d1713 100644
> > --- a/drivers/pci/controller/dwc/pcie-designware.c
> > +++ b/drivers/pci/controller/dwc/pcie-designware.c
> > @@ -671,10 +671,11 @@ void dw_pcie_iatu_detect(struct dw_pcie
> *pci)
> >                 if (!pci->atu_base) {
> >                         struct resource *res =
> >
> platform_get_resource_byname(pdev, IORESOURCE_MEM, "atu");
> > -                       if (res)
> > +                       if (res) {
> >                                 pci->atu_size =
> resource_size(res);
> > -                       pci->atu_base =
> devm_ioremap_resource(dev, res);
> > -                       if (IS_ERR(pci->atu_base))
> > +                               pci->atu_base =
> devm_ioremap_resource(dev, res);
> > +                       }
> > +                       if (!pci->atu_base ||
> IS_ERR(pci->atu_base))
> >                                 pci->atu_base = pci->dbi_base
> + DEFAULT_DBI_ATU_OFFSET;
> >                 }
> >
> > --
> > 2.17.1
> >
> 
> ping - any feedback on this?
> 
> Best regards,
> 
> Tim