linux-kernel - Re: [PATCH] ata: replace snprintf in show functions with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f74c3567-64ff-4bce-89f5-192a1ae9fc45@opensource.wdc.com>
Date:   Thu, 2 Dec 2021 13:19:05 +0900
From:   Damien Le Moal <damien.lemoal@...nsource.wdc.com>
To:     davidcomponentone@...il.com
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
        Yang Guang <yang.guang5@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] ata: replace snprintf in show functions with sysfs_emit

On 2021/11/30 9:04, davidcomponentone@...il.com wrote:
> From: Yang Guang <yang.guang5@....com.cn>
> 
> coccinelle report：
> ./drivers/ata/libata-sata.c:830:8-16: 
> WARNING: use scnprintf or sprintf
> 
> Use sysfs_emit instead of scnprintf or sprintf makes more sense.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Yang Guang <yang.guang5@....com.cn>
> ---
>  drivers/ata/libata-sata.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c
> index 5b78e86e3459..b9c77885b872 100644
> --- a/drivers/ata/libata-sata.c
> +++ b/drivers/ata/libata-sata.c
> @@ -827,7 +827,7 @@ static ssize_t ata_scsi_lpm_show(struct device *dev,
>  	if (ap->target_lpm_policy >= ARRAY_SIZE(ata_lpm_policy_names))
>  		return -EINVAL;
>  
> -	return snprintf(buf, PAGE_SIZE, "%s\n",
> +	return sysfs_emit(buf, "%s\n",
>  			ata_lpm_policy_names[ap->target_lpm_policy]);
>  }
>  DEVICE_ATTR(link_power_management_policy, S_IRUGO | S_IWUSR,
> 

Applied to for-5.16-fixes. Thanks !

-- 
Damien Le Moal
Western Digital Research