[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <YagPJ6aWLKFunWlG@robh.at.kernel.org>
Date: Wed, 1 Dec 2021 18:11:19 -0600
From: Rob Herring <robh@...nel.org>
To: Romain Perier <romain.perier@...il.com>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>,
Thomas Gleixner <tglx@...utronix.de>,
Daniel Palmer <daniel@...f.com>, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] dt-bindings: timer: Add Mstar MSC313e timer
devicetree bindings documentation
On Fri, Nov 26, 2021 at 09:21:42PM +0100, Romain Perier wrote:
> This adds the documentation for the devicetree bindings of the Mstar
> MSC313e timer driver, found from MSC313e SoCs and newer.
>
> Signed-off-by: Romain Perier <romain.perier@...il.com>
> ---
> .../bindings/timer/mstar,msc313e-timer.yaml | 48 +++++++++++++++++++
> 1 file changed, 48 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/timer/mstar,msc313e-timer.yaml
>
> diff --git a/Documentation/devicetree/bindings/timer/mstar,msc313e-timer.yaml b/Documentation/devicetree/bindings/timer/mstar,msc313e-timer.yaml
> new file mode 100644
> index 000000000000..f4d43e141dd0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/mstar,msc313e-timer.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/timer/mstar,msc313e-timer.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mstar MSC313e Timer Device Tree Bindings
> +
> +maintainers:
> + - Daniel Palmer <daniel@...f.com>
> + - Romain Perier <romain.perier@...il.com>
> +
> +properties:
> + compatible:
> + enum:
> + - mstar,msc313e-timer
> + - mstar,ssd20xd-timer
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + start-year: true
This is an rtc property. You would need to $ref rtc.yaml, but then that
also says the node name is 'rtc'. But why do you need a start year for a
clocksource?
> +
> + clocks:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + timer@...0 {
> + compatible = "mstar,msc313e-timer";
> + reg = <0x6040 0x40>;
> + clocks = <&xtal_div2>;
> + interrupts-extended = <&intc_fiq GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +...
> --
> 2.33.0
>
>
Powered by blists - more mailing lists