linux-kernel - RE: [PATCH v11 1/5] device property: Add fwnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY5PR02MB6916F7BC6ACE5326DB92DB2BA9699@BY5PR02MB6916.namprd02.prod.outlook.com>
Date:   Thu, 2 Dec 2021 09:10:02 +0000
From:   Anand Ashok Dumbre <ANANDASH@...inx.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jic23@...nel.org" <jic23@...nel.org>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        git <git@...inx.com>, Michal Simek <michals@...inx.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>
Subject: RE: [PATCH v11 1/5] device property: Add fwnode_iomap()

Hi Andy,

> -----Original Message-----
> From: Anand Ashok Dumbre <ANANDASH@...inx.com>
> Sent: Tuesday 30 November 2021 9:58 PM
> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Cc: linux-kernel@...r.kernel.org; jic23@...nel.org; lars@...afoo.de; linux-
> iio@...r.kernel.org; git <git@...inx.com>; Michal Simek
> <michals@...inx.com>; gregkh@...uxfoundation.org; rafael@...nel.org;
> linux-acpi@...r.kernel.org; heikki.krogerus@...ux.intel.com
> Subject: RE: [PATCH v11 1/5] device property: Add fwnode_iomap()
> 
> Hi Andy,
> 
> Thanks for the review.
> 
> > -----Original Message-----
> > From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Sent: Thursday 25 November 2021 11:42 AM
> > To: Anand Ashok Dumbre <ANANDASH@...inx.com>
> > Cc: linux-kernel@...r.kernel.org; jic23@...nel.org; lars@...afoo.de;
> > linux- iio@...r.kernel.org; git <git@...inx.com>; Michal Simek
> > <michals@...inx.com>; gregkh@...uxfoundation.org; rafael@...nel.org;
> > linux-acpi@...r.kernel.org; heikki.krogerus@...ux.intel.com
> > Subject: Re: [PATCH v11 1/5] device property: Add fwnode_iomap()
> >
> > On Wed, Nov 24, 2021 at 10:54:03PM +0000, Anand Ashok Dumbre wrote:
> > > This patch introduces a new helper routine - fwnode_iomap(), which
> > > allows to map the memory mapped IO for a given device node.
> > >
> > > This implementation does not cover the ACPI case and may be expanded
> > > in the future. The main purpose here is to be able to develop
> > > resource provider agnostic drivers.
> >
> > ...
> >
> > > +void __iomem *fwnode_iomap(struct fwnode_handle *fwnode, int
> > index) {
> >
> > > +	if (is_of_node(fwnode))
> > > +		return of_iomap(to_of_node(fwnode), index);
> >
> > It seems this part should be wrapped in some ifdeffery according to
> > kbuild bot report.
> 
> I see that of_iomap is wrapped in #ifdef I will fix that and send a new patch.

I am unable to reproduce the conditions for the error shown by the kernel bot.
Not sure if I am doing something wrong. Any help/suggestion would be appreciated to fix this issue.

> 
> >
> > > +	return NULL;
> > > +}
> > > +EXPORT_SYMBOL(fwnode_iomap);
> >
> > --
> > With Best Regards,
> > Andy Shevchenko
> >
> 
> Thanks,
> Anand

Thanks and Regards,
Anand