linux-kernel - [PATCH] mfd: lpc_ich: convert name to const char*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <223bc330-5be1-136b-7b42-e4bc1331d28f@gmail.com>
Date:   Thu, 2 Dec 2021 10:42:51 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Peter Tyser <ptyser@...-inc.com>, Lee Jones <lee.jones@...aro.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: [PATCH] mfd: lpc_ich: convert name to const char*

This change reduces the memory footprint of the structs (admittedly
not much), and it allows the compiler to store names only once.
E.g. i2c-i801 uses name "Intel PCH" twice. All users assign static
strings to name, and only usage of name is in iTCO_wdt_probe() for
printing a syslog info message. So we don't really have to worry
about potential issues like use after free.

Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
---
 drivers/mfd/lpc_ich.c                  | 2 +-
 include/linux/mfd/lpc_ich.h            | 2 +-
 include/linux/platform_data/itco_wdt.h | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
index f10e53187..acb33a180 100644
--- a/drivers/mfd/lpc_ich.c
+++ b/drivers/mfd/lpc_ich.c
@@ -889,7 +889,7 @@ static int lpc_ich_finalize_wdt_cell(struct pci_dev *dev)
 	info = &lpc_chipset_info[priv->chipset];
 
 	pdata->version = info->iTCO_version;
-	strlcpy(pdata->name, info->name, sizeof(pdata->name));
+	pdata->name = info->name;
 
 	cell->platform_data = pdata;
 	cell->pdata_size = sizeof(*pdata);
diff --git a/include/linux/mfd/lpc_ich.h b/include/linux/mfd/lpc_ich.h
index 39967a5ec..6dec7d992 100644
--- a/include/linux/mfd/lpc_ich.h
+++ b/include/linux/mfd/lpc_ich.h
@@ -27,7 +27,7 @@ enum {
 };
 
 struct lpc_ich_info {
-	char name[32];
+	const char *name;
 	unsigned int iTCO_version;
 	unsigned int gpio_version;
 	enum intel_spi_type spi_type;
diff --git a/include/linux/platform_data/itco_wdt.h b/include/linux/platform_data/itco_wdt.h
index 45d860cac..c6941c089 100644
--- a/include/linux/platform_data/itco_wdt.h
+++ b/include/linux/platform_data/itco_wdt.h
@@ -19,7 +19,7 @@
  * @no_reboot_use_pmc: Use PMC BXT API to set and clear NO_REBOOT bit
  */
 struct itco_wdt_platform_data {
-	char name[32];
+	const char *name;
 	unsigned int version;
 	bool no_reboot_use_pmc;
 };
-- 
2.34.1