linux-kernel - Re: [PATCH] media: i2c: Fix inconsistent indenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4803fe17-fdce-dbcc-99e7-29e0715dfee9@gmail.com>
Date:   Thu, 2 Dec 2021 09:47:59 +0000
From:   Daniel Scally <djrscally@...il.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, mchehab@...nel.org
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: i2c: Fix inconsistent indenting

Hi Jiapeng


Thanks for catching that

On 02/12/2021 08:39, Jiapeng Chong wrote:
> Eliminate the follow smatch warning:
>
> drivers/media/i2c/ov8865.c:2841 ov8865_get_selection() warn:
> inconsistent indenting.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>


Reviewed-by: Daniel Scally <djrscally@...il.com>

> ---
>  drivers/media/i2c/ov8865.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c
> index ebdb20d..09ba13f 100644
> --- a/drivers/media/i2c/ov8865.c
> +++ b/drivers/media/i2c/ov8865.c
> @@ -2836,8 +2836,7 @@ static int ov8865_get_selection(struct v4l2_subdev *subdev,
>  	switch (sel->target) {
>  	case V4L2_SEL_TGT_CROP:
>  		mutex_lock(&sensor->mutex);
> -			__ov8865_get_pad_crop(sensor, state, sel->pad,
> -					      sel->which, &sel->r);
> +		__ov8865_get_pad_crop(sensor, state, sel->pad, sel->which, &sel->r);
>  		mutex_unlock(&sensor->mutex);
>  		break;
>  	case V4L2_SEL_TGT_NATIVE_SIZE: