linux-kernel - Re: [PATCH] dt-bindings: net: cdns,macb: Convert to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Dec 2021 11:10:01 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Rob Herring <robh@...nel.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        netdev <netdev@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Michal Simek <michal.simek@...inx.com>
Subject: Re: [PATCH] dt-bindings: net: cdns,macb: Convert to json-schema

Hi Rob,

CC Michal

On Thu, Dec 2, 2021 at 12:25 AM Rob Herring <robh@...nel.org> wrote:
> On Fri, Nov 26, 2021 at 12:57:00PM +0100, Geert Uytterhoeven wrote:
> > Convert the Cadence MACB/GEM Ethernet controller Device Tree binding
> > documentation to json-schema.
> >
> > Re-add "cdns,gem" (removed in commit a217d8711da5c87f ("dt-bindings:
> > Remove PicoXcell bindings")) as there are active users on non-PicoXcell
> > platforms.
> > Add missing "ether_clk" clock.
> > Add missing properties.
> >
> > Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml

> > +  '#stream-id-cells':
> > +    const: 1
>
> I can't figure out why you have this here. I'll drop it while applying.

See arch/arm64/boot/dts/xilinx/zynqmp.dtsi and
drivers/iommu/arm/arm-smmu/arm-smmu.c.

It wasn't clear to me if this is still needed, or legacy. Michal?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds