lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20211202103645.rjzjsrb7szue3j4l@e107158-lin.cambridge.arm.com>
Date:   Thu, 2 Dec 2021 10:36:45 +0000
From:   Qais Yousef <qais.yousef@....com>
To:     Dietmar Eggemann <dietmar.eggemann@....com>
Cc:     Valentin Schneider <valentin.schneider@....com>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/uclamp: Fix rq->uclamp_max not set on first enqueue

On 12/01/21 10:20, Dietmar Eggemann wrote:
> On 30.11.21 16:41, Qais Yousef wrote:
> > On 11/30/21 12:29, Valentin Schneider wrote:
> >> On 30/11/21 11:23, Qais Yousef wrote:
> >>> Hi Valentin
> >>>
> >>> On 11/26/21 10:51, Valentin Schneider wrote:
> >>>> On 25/11/21 16:52, Qais Yousef wrote:
> >>>>> Commit d81ae8aac85c ("sched/uclamp: Fix initialization of struct
> >>>>> uclamp_rq") introduced a bug where uclamp_max of the rq is not reset to
> >>>>> match the woken up task's uclamp_max when the rq is idle. This only
> >>>>> impacts the first wake up after enabling the static key. And it only
> 
> LGTM.
> 
> Tested-by: Dietmar Eggemann <dietmar.eggemann@....com>

Thanks!

--
Qais Yousef

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ