linux-kernel - Re: [PATCH v2] arm64: Enable KCSAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANpmjNOOVQjoczanQndUoDRMCOfV4FB6bnezEjskKh3iDzaQVg@mail.gmail.com>
Date:   Thu, 2 Dec 2021 11:58:20 +0100
From:   Marco Elver <elver@...gle.com>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>
Cc:     Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        joey.gouly@....com
Subject: Re: [PATCH v2] arm64: Enable KCSAN

On Thu, 2 Dec 2021 at 11:45, Kefeng Wang <wangkefeng.wang@...wei.com> wrote:
[...]
> >> for now and more explanation into changlog.
> > So what I gather arm64's final select line may look like:
> >
> >       select HAVE_ARCH_KCSAN if EXPERT && (CC_IS_GCC || CLANG_VERSION >= 120000)
> Yes,  that's what we want now.

I think we have all the pieces sorted out, so hopefully you have
everything you need to do v3.

[...]
> > I actually have a "fix" for the data race in rwsem_spin_on_owner, that
> > also shows where the other racing access comes from... which reminds me:
> > https://lkml.kernel.org/r/20211202101238.33546-1-elver@google.com
>
> There's a owner_on_cpu(),  we could reuse it,

That looks like a reasonable thing to do, but can't say if it is
actually the right thing to do. You could suggest it in reply to the
patch I just sent and see what people say.

Thanks,
-- Marco