[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <DCEC0C45-D974-4DC7-9E86-8F2D3D8F7E1D@live.com>
Date: Thu, 2 Dec 2021 12:41:59 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: Marcel Holtmann <marcel@...tmann.org>
CC: Greg KH <gregkh@...uxfoundation.org>,
Thorsten Leemhuis <regressions@...mhuis.info>,
Orlando Chamberlain <redecorating@...tonmail.com>,
Daniel Winkler <danielwinkler@...gle.com>,
Johan Hedberg <johan.hedberg@...el.com>,
"linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Luiz Augusto von Dentz <luiz.dentz@...il.com>,
"regressions@...ts.linux.dev" <regressions@...ts.linux.dev>,
"sonnysasaka@...omium.org" <sonnysasaka@...omium.org>,
"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: [PATCH v10 1/2] Bluetooth: add quirk disabling LE Read Transmit Power
From: Aditya Garg <gargaditya08@...e.com>
Some devices have a bug causing them to not work if they query
LE tx power on startup. Thus we add a quirk in order to not query it
and default min/max tx power values to HCI_TX_POWER_INVALID.
Signed-off-by: Aditya Garg <gargaditya08@...e.com>
Reported-by: Orlando Chamberlain <redecorating@...tonmail.com>
Tested-by: Orlando Chamberlain <redecorating@...tonmail.com>
Link:
https://lore.kernel.org/r/4970a940-211b-25d6-edab-21a815313954@protonmail.com
Fixes: 7c395ea521e6 ("Bluetooth: Query LE tx power on startup")
Cc: stable@...r.kernel.org
---
v7 :- Added Tested-by.
v8 :- Fix checkpatch error.
v9 :- Remake patch for Bluetooth-next tree and add Cc: stable@...r.kernel.org
v10 :- Fix gitlint
include/net/bluetooth/hci.h | 9 +++++++++
net/bluetooth/hci_sync.c | 3 ++-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
index 0d2a92168..c4959cf9a 100644
--- a/include/net/bluetooth/hci.h
+++ b/include/net/bluetooth/hci.h
@@ -246,6 +246,15 @@ enum {
* HCI after resume.
*/
HCI_QUIRK_NO_SUSPEND_NOTIFIER,
+
+ /*
+ * When this quirk is set, LE tx power is not queried on startup
+ * and the min/max tx power values default to HCI_TX_POWER_INVALID.
+ *
+ * This quirk can be set before hci_register_dev is called or
+ * during the hdev->setup vendor callback.
+ */
+ HCI_QUIRK_BROKEN_READ_TRANSMIT_POWER,
};
/* HCI device flags */
diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index ad86caf41..52e6b5dae 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -3283,7 +3283,8 @@ static int hci_le_read_adv_tx_power_sync(struct hci_dev *hdev)
/* Read LE Min/Max Tx Power*/
static int hci_le_read_tx_power_sync(struct hci_dev *hdev)
{
- if (!(hdev->commands[38] & 0x80))
+ if (!(hdev->commands[38] & 0x80) ||
+ test_bit(HCI_QUIRK_BROKEN_READ_TRANSMIT_POWER, &hdev->quirks))
return 0;
return __hci_cmd_sync_status(hdev, HCI_OP_LE_READ_TRANSMIT_POWER,
--
2.25.1
Powered by blists - more mailing lists