linux-kernel - Re: [PATCH] NFSD: Fix inconsistent indenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6609E132-FDDA-490B-B1F5-C6823EB85834@oracle.com>
Date:   Thu, 2 Dec 2021 16:29:14 +0000
From:   Chuck Lever III <chuck.lever@...cle.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
CC:     Bruce Fields <bfields@...ldses.org>,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] NFSD: Fix inconsistent indenting



> On Dec 2, 2021, at 3:35 AM, Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> wrote:
> 
> Eliminate the follow smatch warning:
> 
> fs/nfsd/nfs4xdr.c:4766 nfsd4_encode_read_plus_hole() warn: inconsistent
> indenting.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
> fs/nfsd/nfs4xdr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index c286690..3031126 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -4763,8 +4763,8 @@ static __be32 nfsd4_encode_readv(struct nfsd4_compoundres *resp,
> 		return nfserr_resource;
> 
> 	*p++ = htonl(NFS4_CONTENT_HOLE);
> -	 p   = xdr_encode_hyper(p, read->rd_offset);
> -	 p   = xdr_encode_hyper(p, count);
> +	p = xdr_encode_hyper(p, read->rd_offset);
> +	p = xdr_encode_hyper(p, count);
> 
> 	*eof = (read->rd_offset + count) >= f_size;
> 	*maxcount = min_t(unsigned long, count, *maxcount);
> -- 
> 1.8.3.1
> 

Thanks! I've included this patch in my for-next topic branch.

--
Chuck Lever