linux-kernel - Re: [PATCH] media: s5p-jpeg: Constify struct v4l2_m2m

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 3 Dec 2021 20:22:40 +0100
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Rikard Falkeborn <rikard.falkeborn@...il.com>,
        Andrzej Pietrasiewicz <andrzejtp2010@...il.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: s5p-jpeg: Constify struct v4l2_m2m_ops

Hi Rikard,

Thanks for the patch.

On 11/30/21 10:27 PM, Rikard Falkeborn wrote:
> The only usage of the v4l2_m2m_ops structs is to pass their address to
> v4l2_m2m_init() which takes a pointer to const struct v4l2_m2m_ops as
> argument. Make them const to allow the compiler to put them in read-only
> memory.
> 
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@...il.com>
> ---
>   drivers/media/platform/s5p-jpeg/jpeg-core.c | 6 +++---
>   drivers/media/platform/s5p-jpeg/jpeg-core.h | 2 +-
>   2 files changed, 4 insertions(+), 4 deletions(-)

Acked-by: Jacek Anaszewski <jacek.anaszewski@...il.com>

-- 
Best regards,
Jacek Anaszewski