linux-kernel - [PATCH v3] PCI: mt7621: Convert driver into 'bool'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211203192454.32624-1-sergio.paracuellos@gmail.com>
Date:   Fri,  3 Dec 2021 20:24:54 +0100
From:   Sergio Paracuellos <sergio.paracuellos@...il.com>
To:     linux-pci@...r.kernel.org
Cc:     tsbogend@...ha.franken.de, lorenzo.pieralisi@....com,
        bhelgaas@...gle.com, arnd@...db.de, linux@...ck-us.net,
        linux-kernel@...r.kernel.org
Subject: [PATCH v3] PCI: mt7621: Convert driver into 'bool'

Driver is not ready yet to be compiled as a module since it depends on some
MIPS not exported symbols. We have the following current problems:

Building mips:allmodconfig ... failed
--------------
Error log:
ERROR: modpost: missing MODULE_LICENSE() in drivers/pci/controller/pcie-mt7621.o
ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined!
ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined!
ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined!
ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined!
ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined!

Temporarily move from 'tristate' to 'bool' until a better solution is ready.

Also RALINK is redundant because SOC_MT7621 already depends on it. Hence,
simplify condition.

Fixes: 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver").
Reviewed-and-tested-by: Guenter Roeck <linux@...ck-us.net>
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@...il.com>
---
Changes in v3:
 - Adjust subject to follow convention:
    s/PCI: mt7621: Kconfig:/PCI: mt7621:/
Changes in v2:
 - Add Guenter's 'Reviewed-and-tested-by'.
 - s/after/until
 drivers/pci/controller/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
index 93b141110537..7fc5135ffbbf 100644
--- a/drivers/pci/controller/Kconfig
+++ b/drivers/pci/controller/Kconfig
@@ -332,8 +332,8 @@ config PCIE_APPLE
 	  If unsure, say Y if you have an Apple Silicon system.
 
 config PCIE_MT7621
-	tristate "MediaTek MT7621 PCIe Controller"
-	depends on (RALINK && SOC_MT7621) || (MIPS && COMPILE_TEST)
+	bool "MediaTek MT7621 PCIe Controller"
+	depends on SOC_MT7621 || (MIPS && COMPILE_TEST)
 	select PHY_MT7621_PCI
 	default SOC_MT7621
 	help
-- 
2.33.0