linux-kernel - Re: [PATCH v3] staging: fieldbus: replace snprintf with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 3 Dec 2021 08:18:55 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     davidcomponentone@...il.com
Cc:     TheSven73@...il.com, dan.carpenter@...cle.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Yang Guang <yang.guang5@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH v3] staging: fieldbus: replace snprintf with sysfs_emit

On Fri, Dec 03, 2021 at 09:17:32AM +0800, davidcomponentone@...il.com wrote:
> From: Yang Guang <yang.guang5@....com.cn>

Does not match the address you send this email from as reported many
times to you.

> 
> coccinelle report:
> ./drivers/staging/fieldbus/dev_core.c:73:8-16:
> WARNING: use scnprintf or sprintf
> 
> Use sysfs_emit instead of scnprintf or sprintf makes more sense.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>

Again, I have commented on the use of this many times already.  I will
not take this change until you at least discuss it with us.

sorry,

greg k-h